fix(contracts): add stream_count view fn and fix resume_stream status… - #988
Open
Anthony-19 wants to merge 4 commits into
Open
fix(contracts): add stream_count view fn and fix resume_stream status…#988Anthony-19 wants to merge 4 commits into
Anthony-19 wants to merge 4 commits into
Conversation
… guard Closes LabsCrypt#421 — stream_count() -> u64 - Add stream_count() read-only function that returns the global StreamCounter value (monotonically increasing, equals the highest stream ID ever issued, never decrements on cancel/complete). - Returns 0 on a freshly-deployed contract with no streams. - Add TypeScript binding fetchStreamCount() in frontend/src/lib/soroban.ts that simulates the view call without wallet auth. - Unit tests: stream_count_returns_zero_on_fresh_contract, stream_count_increments_by_one_per_create, stream_count_is_not_decremented_by_cancel, stream_count_matches_last_stream_id. Closes LabsCrypt#787 — resume_stream status guard - resume_stream now checks stream.status == Paused (not just stream.paused), so a stream cancelled while paused (status=Cancelled, paused=true) correctly returns StreamInactive instead of being resurrected to Active. - cancel_stream now explicitly clears stream.paused = false and stream.paused_at = None when settling a cancellation, ensuring no stale pause state survives into the Cancelled record. - Unit tests: resume_after_cancel_while_paused_returns_stream_inactive, cancel_while_paused_clears_pause_fields, cancel_normal_stream_also_clears_pause_fields.
…tream The pause state clearance (paused=false, paused_at=None) was placed after the CEI-refactored save_stream call, putting it inside the interactions block where token_client/contract_address are in scope but stream state mutations should not happen. Move the two lines up into the effects block, before save_stream, consistent with the existing is_active/status/last_update_time assignments.
Anthony-19
force-pushed
the
anthony_flowfi
branch
from
July 4, 2026 11:11
6e6a925 to
eaf5796
Compare
# Conflicts: # contracts/stream_contract/src/lib.rs
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
two genuinely valuable things in here: stream_count still does not exist on main, and the cancelled-while-paused hole is real (cancel_stream never clears paused, and resume_stream only checks !stream.paused, so a cancelled stream can be resumed to Active). to land it:
- fix the file encoding: the diff mojibakes every UTF-8 character in lib.rs (em dashes become garbage), which corrupts docs file-wide. save as UTF-8 so the diff touches only real lines.
- rebase onto main: resume_stream was rewritten there, so re-apply just the Paused-status guard, and clear paused in cancel_stream too.
- drop or justify the frontend/soroban.ts change.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… guard
Closes #421 — stream_count() -> u64
Closes #787 — resume_stream status guard
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes